Switch over to iconPath#8838
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the extension’s chat context items and proposed VS Code type definitions to use iconPath (instead of icon) and bumps the declared VS Code engine version accordingly.
Changes:
- Switch chat context item construction in LM context providers from
icontoiconPath. - Update proposed
ChatContextItemtyping/docs to exposeiconPath?: IconPathinstead oficon?: ThemeIcon. - Bump
engines.vscodefrom^1.129.0to^1.130.0(and reflect it inpackage-lock.json).
Show a summary per file
| File | Description |
|---|---|
| src/lm/pullRequestContextProvider.ts | Uses iconPath for PR/workspace chat context items. |
| src/lm/issueContextProvider.ts | Uses iconPath for issue chat context items. |
| src/@types/vscode.proposed.chatContextProvider.d.ts | Renames ChatContextItem.icon to iconPath and updates related docs (with some doc cleanup needed). |
| src/@types/vscode.proposed.chatSessionsProvider.d.ts | Adds promo metadata to model hover metadata (scope appears broader than PR title). |
| package.json | Bumps minimum VS Code engine version to ^1.130.0. |
| package-lock.json | Mirrors the VS Code engine bump. |
Review details
- Files reviewed: 3/6 changed files
- Comments generated: 0
- Review effort level: Low
chrmarti
approved these changes
Jul 14, 2026
Member
Author
|
@microsoft-github-policy-service rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.